[PATCH] D124342: [X86][AMX] Report error when shapes are not pre-defined.

[Phoebe Wang via Phabricator via llvm-commits]

pengfei added inline comments.


================
Comment at: llvm/lib/Target/X86/X86PreTileConfig.cpp:52
+  Context.emitError(ErrorMsg);
+  exit(1);
+}
----------------
Any benefit to use `exit`? I found we seldom use it in the code.


================
Comment at: llvm/test/CodeGen/X86/AMX/amx-error.ll:8
+entry:
+  ; CHECK: Failed to config tile register
+  %t0 = load i16, ptr @row, align 2
----------------
Doesn't it success without this patch? https://godbolt.org/z/qvKcE3bzK


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124342/new/

https://reviews.llvm.org/D124342