[PATCH] D122563: [RISCV] Add DAGCombine to fold base operation and reduction.
Fraser Cormack via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Apr 24 00:28:25 PDT 2022
frasercrmck added a comment.
In D122563#3469797 <https://reviews.llvm.org/D122563#3469797>, @fakepaper56 wrote:
> Since we need to transform `VECREDUCE` to `VP_REDUCE` before legalization for Fraser's method, we need to deal with illegal type of `VECREDUCE`. If we don't have idea to deal with illegal type nodes of `VECREDUCE`, how about we just use my original combine?
Yeah, this patch is good as it is Thanks for going along with my suggestion and finding out what still needs to be done! Sorry for not getting back to you promptly.
As Craig says, LGTM with his request.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122563/new/
https://reviews.llvm.org/D122563
More information about the llvm-commits
mailing list