[PATCH] D123679: [RISCV] Don't getDebugLoc for the end node of MBB iterator

[luxufan via Phabricator via llvm-commits]

StephenFan updated this revision to Diff 424761.
StephenFan added a comment.

ChangeLoc:

Use update_mir_test_checks.py to autogenerate check lines


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123679/new/

https://reviews.llvm.org/D123679

Files:
  llvm/lib/Target/RISCV/RISCVFrameLowering.cpp
  llvm/test/CodeGen/RISCV/pr53662.mir


Index: llvm/test/CodeGen/RISCV/pr53662.mir
===================================================================
--- /dev/null
+++ llvm/test/CodeGen/RISCV/pr53662.mir
@@ -0,0 +1,38 @@
+# NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py
+# RUN: llc -mtriple=riscv64 -run-pass=prologepilog -o - %s | FileCheck %s
+--- |
+  define void @b() {
+  entry:
+    unreachable
+  }
+
+...
+---
+name:            b
+frameInfo:
+  savePoint:       '%bb.0'
+  restorePoint:    '%bb.1'
+body:             |
+  ; CHECK-LABEL: name: b
+  ; CHECK: bb.0:
+  ; CHECK-NEXT:   successors: %bb.1(0x80000000)
+  ; CHECK-NEXT: {{  $}}
+  ; CHECK-NEXT:   PseudoBR %bb.1
+  ; CHECK-NEXT: {{  $}}
+  ; CHECK-NEXT: bb.1:
+  ; CHECK-NEXT:   successors: %bb.2(0x80000000)
+  ; CHECK-NEXT: {{  $}}
+  ; CHECK-NEXT:   DBG_VALUE $noreg
+  ; CHECK-NEXT: {{  $}}
+  ; CHECK-NEXT: bb.2:
+  ; CHECK-NEXT:   PseudoRET implicit killed $x10
+  bb.0 :
+    PseudoBR %bb.1
+
+  bb.1:
+    DBG_VALUE $noreg
+
+  bb.2:
+    PseudoRET implicit killed $x10
+
+...
Index: llvm/lib/Target/RISCV/RISCVFrameLowering.cpp
===================================================================
--- llvm/lib/Target/RISCV/RISCVFrameLowering.cpp
+++ llvm/lib/Target/RISCV/RISCVFrameLowering.cpp
@@ -561,15 +561,11 @@
   MachineBasicBlock::iterator MBBI = MBB.end();
   DebugLoc DL;
   if (!MBB.empty()) {
+    MBBI = MBB.getLastNonDebugInstr();
+    if (MBBI != MBB.end())
+      DL = MBBI->getDebugLoc();
+
     MBBI = MBB.getFirstTerminator();
-    if (MBBI == MBB.end())
-      MBBI = MBB.getLastNonDebugInstr();
-    DL = MBBI->getDebugLoc();
-
-    // If this is not a terminator, the actual insert location should be after the
-    // last instruction.
-    if (!MBBI->isTerminator())
-      MBBI = std::next(MBBI);
 
     // If callee-saved registers are saved via libcall, place stack adjustment
     // before this call.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D123679.424761.patch
Type: text/x-patch
Size: 1896 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220424/3cd52564/attachment.bin>