[PATCH] D124085: [CodeGen] Fix assertion failure on large types store

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/CodeGen/CodeGenPrepare.cpp:7463
+  if (HalfValBitSize > IntegerType::MAX_INT_BITS)
+    return false;
+
----------------
RKSimon wrote:
> Isn't this hard-coded to unsigned/uint32_t? What about exposing a typedef in SDNode instead so we can use std::numeric_limits? .
MAX_INT_BITS is 1<<23. It's related to there being 24 bits of subclass data available in llvm::Type


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124085/new/

https://reviews.llvm.org/D124085