[PATCH] D124336: [lld/mac] For catalyst outputs, tolerate implicitly linking against mac-only tbd files

Sat Apr 23 11:36:12 PDT 2022

thakis added inline comments.

================
Comment at: lld/MachO/DriverUtils.cpp:212
+    if (explicitlyLinked)
+      file->explicitlyLinked = explicitlyLinked;
     return file;
----------------
Setting this on an already-loaded dylib is needed for the `%t/foo_with_bar.dylib %t/bar.dylib` case in line 29 in dead-strip-dylibs.s.

For tbd files, this means if a tbd file is loaded implicitly at first and then explicitly later on, we won't emit the diag. But I think at least once https://github.com/llvm/llvm-project/issues/55042 is fixed, you can't explicitly link a tbd's implicit exports?

In practice, I think this is probably fine as-is.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124336/new/

https://reviews.llvm.org/D124336