[PATCH] D124293: [SLP][NFC] Pre-commit test showing deficiency in current roots selection algorithm

[Alexey Bataev via Phabricator via llvm-commits]

ABataev added inline comments.


================
Comment at: llvm/test/Transforms/SLPVectorizer/X86/vectorize-pair-path.ll:48
+  %i03 = fmul fast double undef, %i02
+  %i04 = fsub fast double %i03, undef
+  %i05 = fmul fast double %i04, 4.0
----------------
RKSimon wrote:
> Why are there undef float-ops? Is this the only way to expose the issue? If you run this through opt -O3 all you get is a posion result.
It is ok for SLP to have some undefs unless you do not use instcombine. You can treat undef here as a specific op kind, different from others. Just to reduce the size of the test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124293/new/

https://reviews.llvm.org/D124293