[PATCH] D124266: [lld/elf] fix quote usage in section names

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/test/ELF/linkerscript/section-quotes.test:4
+
+# RUN: echo '.globl _start; _start: ret; \
+# RUN:   .data; .byte 0; \
----------------
Use `split-file` to provide the linker script


================
Comment at: lld/test/ELF/linkerscript/section-quotes.test:19
+  ".text" : AT(ADDR(".text")) {
+    LONG (ALIGNOF(".text"))
+    LONG (LOADADDR(".text"))
----------------
Just keep ALIGNOF for .text and keep LOADADDR for .data? That provides sufficient coverage without being too verbose.


================
Comment at: lld/test/ELF/linkerscript/section-quotes.test:23
+  }
+  text_size = SIZEOF(".text");
+  .data : AT(ADDR(".data")) {
----------------
Unused. Delete


================
Comment at: lld/test/ELF/linkerscript/section-quotes.test:29
+  }
+  data_size = SIZEOF(".data");
+  ".bss" : AT(ADDR(.bss)) {
----------------
Unused. Delete


================
Comment at: lld/test/ELF/linkerscript/section-quotes.test:35
+  }
+  bss_size = SIZEOF(.bss);
+}
----------------
Unused. Delete


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124266/new/

https://reviews.llvm.org/D124266