[PATCH] D124315: lld: Bundle compact_unwind_encoding.h in lld to fix stand-alone builds

Fri Apr 22 20:15:15 PDT 2022

tstellar added a comment.

In D124315#3469495 <https://reviews.llvm.org/D124315#3469495>, @smeenai wrote:

> In D124315#3469458 <https://reviews.llvm.org/D124315#3469458>, @tstellar wrote:
>
>> In D124315#3469449 <https://reviews.llvm.org/D124315#3469449>, @smeenai wrote:
>>
>>> To be clear, this is to support a build scenario where you only have the source tree under `lld` available?
>>
>> Yes, that's correct.
>
> Ah, I'd missed that part of the definition in https://discourse.llvm.org/t/rfc-stand-alone-build-support/61291. Thanks for confirming.
>
> The duplication here is really unfortunate, especially cos the burden of keeping the copied header up-to-date will fall on non-standalone build users. On the other hand, this header hasn't seen actual (non-license) update since 2016, so I imagine it'll remain pretty stable going forward.

Yes, I tried to ease this burden a little bit by failing the build if the bundled file was different than the version in libunwind, so at least buildbots would catch it and notify whoever modified the file in libunwind.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124315/new/

https://reviews.llvm.org/D124315