[PATCH] D120232: [SelectOpti][4/5] Loop Heuristics
Sotiris Apostolakis via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Apr 22 15:48:04 PDT 2022
apostolakis added a comment.
In D120232#3460939 <https://reviews.llvm.org/D120232#3460939>, @davidxl wrote:
> A high level comment. I saw ScalingUpFactor is used in many places. It may be better to directly use Scaled64 data type instead of uint64 to avoid that.
I used ScalingUpFactor to get a decent precision without increasing compile time (due to non-integer ops), but it is a bit hacky and it seems better to directly use Scaled64.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120232/new/
https://reviews.llvm.org/D120232
More information about the llvm-commits
mailing list