[PATCH] D124302: [llvm][misexpect] Replace assertion with early return

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 22 15:33:17 PDT 2022


tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.

lgtm

Sure, that seems fine to me. I would add a FIXME to add back the assert as well. There are a few typos in the patch description, can you fix those before submitting?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124302/new/

https://reviews.llvm.org/D124302



More information about the llvm-commits mailing list