[PATCH] D124302: [llvm][misexpect] Replace assertion with early return

[Paul Kirth via Phabricator via llvm-commits]

paulkirth added a comment.

In D124302#3469104 <https://reviews.llvm.org/D124302#3469104>, @tejohnson wrote:

> The failing test case was with SamplePGO. I went back and looked at the original patch and realized that it doesn't seem to have any test cases for SamplePGO, even though it is being called there. It probably makes sense to look more closely at the IR in that case to see how this code is getting the 0 "expected" edge weights. Rather than this change, how about disabling misexpect verification for sample PGO as a short term fix, then doing some investigation and adding a fix along with sample PGO tests when re-enabling it there?

That seems like a reasonable choice. I'm a bit apprehensive about relying on the assert to prevent this type of error though. Maybe we do both for now?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124302/new/

https://reviews.llvm.org/D124302