[PATCH] D124056: [ELF] Fix wrapping symbols produced during LTO codegen
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Apr 22 15:14:43 PDT 2022
MaskRay added inline comments.
================
Comment at: lld/ELF/SymbolTable.cpp:47
+ sym->isUsedInRegularObj = true;
+ else if (sym->isUndefined())
sym->isUsedInRegularObj = false;
----------------
smeenai wrote:
> MaskRay wrote:
> > It will be good to have a comment for the `if (sym->isUndefined())` condition.
> Note that I'm tightening the condition further in D124065, which is a follow-up to this diff. Would you prefer adding a comment here and then changing it in D124065, or just adding the comment in D124065? (I think it'll be easier to explain the logic of the conditional with the change in D124065.)
Ah adding the comment to D124065 will be good.
Are you splitting the two patches for easy bisection? I.e. in case the second patch breaks something?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124056/new/
https://reviews.llvm.org/D124056
More information about the llvm-commits
mailing list