[PATCH] D124293: [SLP][NFC] Pre-commit test showing deficiency in current roots selection algorithm

[Valeriy Dmitriev via Phabricator via llvm-commits]

vdmitrie marked an inline comment as done.
vdmitrie added inline comments.


================
Comment at: llvm/test/Transforms/SLPVectorizer/X86/vectorize-pair-path.ll:6
+target triple = "x86_64-unknown-linux-gnu"
+
+define double @foo(double %a, double %b, double %c, double %d) local_unnamed_addr #0 {
----------------
vporpo wrote:
> vdmitrie wrote:
> > vporpo wrote:
> > > Please explain briefly in a comment which roots should be selected instead of the current ones.
> > Here we start trying to vectorize reduction but end up in tryToVectorize() method which then makes several attempts of finding something that can be vectorized.
> > The way it makes probes for various pairs is predefined by its implementation. That is what I mean here by "path". 
> > 
> Sounds good, please add some of this text in the test so that whoever reads it knows what it is about.
Thank you. I added description to make its purpose clearer.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124293/new/

https://reviews.llvm.org/D124293