[PATCH] D124267: [MachinePipeliner] Fix unscheduled instruction
Brendon Cahoon via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Apr 22 13:43:27 PDT 2022
bcahoon added inline comments.
================
Comment at: llvm/lib/CodeGen/MachinePipeliner.cpp:1582
for (auto &PI : Cur->Preds)
- if (PI.getKind() == SDep::Anti)
+ if (PI.getKind() == SDep::Anti && !ignoreDependence(PI, true))
FoundPath |=
----------------
I don't think this if condition will ever be true? If PI.getKind() == SDep::Anti, then ignoreDepedendence(PI, true) will also return true, so this condition evaluates to if (true && false).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124267/new/
https://reviews.llvm.org/D124267
More information about the llvm-commits
mailing list