[PATCH] D124293: [SLP][NFC] Pre-commit test showing deficiency in current roots selection algorithm

[Vasileios Porpodas via Phabricator via llvm-commits]

vporpo added a comment.

The test filename is `vectorize-pair-path.ll`, but the description says that this test is about root selection, so perhaps rename it to something like `root-selection.ll`? The impression I am getting from the current name is that this test is about the path followed by `buildTreeRec()`.



================
Comment at: llvm/test/Transforms/SLPVectorizer/X86/vectorize-pair-path.ll:6
+target triple = "x86_64-unknown-linux-gnu"
+
+define double @foo(double %a, double %b, double %c, double %d) local_unnamed_addr #0 {
----------------
Please explain briefly in a comment which roots should be selected instead of the current ones.


================
Comment at: llvm/test/Transforms/SLPVectorizer/X86/vectorize-pair-path.ll:7
+
+define double @foo(double %a, double %b, double %c, double %d) local_unnamed_addr #0 {
+; CHECK-LABEL: @foo(
----------------
Nit: perhaps a more relevant function name, like `root_selection` or something similar.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124293/new/

https://reviews.llvm.org/D124293