[PATCH] D124125: [NVPTX][tests] add "XFAIL: nvptx" for some tests

[Artem Belevich via Phabricator via llvm-commits]

tra added inline comments.


================
Comment at: llvm/test/CodeGen/Generic/inline-asm-mem-clobber.ll:6
 
+; NVPTX output seems valid, but not what the test expects
+; XFAIL: nvptx
----------------
tra wrote:
> This test should've used `CHECK-DAG` as the order in which code/data is emitted is not guaranteed.
> It should also have used `G` when it was checking for the variable name.  `@G` is only used in  a comment in the x86 assembly.
I think this test should be fixed instead of disabling it.


================
Comment at: llvm/test/CodeGen/Generic/live-debug-label.ll:41-44
 ; CHECK: bye.thread21:
 ; CHECK: DBG_LABEL !14
 ; CHECK: if.then5:
 ; CHECK: DBG_LABEL !14
----------------
i-chebykin wrote:
> tra wrote:
> > Something like this would probably work better:
> > ```
> > ; CHECK: {{bye\.thread21|if\.then5}}:
> > ; CHECK: DBG_LABEL !14
> > ; Skip to the next label.
> > ; CHECK: {{^\s+bb\.}}
> > ; CHECK: {{bye\.thread21|if\.then5}}:
> > ; CHECK: DBG_LABEL !14
> > ; Skip to the next label.
> > ; CHECK: {{^\s+bb\.}}
> > ; CHECK-NOT: DBG_LABEL !14
> > 
> > ```
> 
> Not sure that we can have simple test for both x86 and nvptx here
> I suggest either `XFAIL: nvptx` or do not touch the test in this commit
OK.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124125/new/

https://reviews.llvm.org/D124125