[PATCH] D124125: [NVPTX][tests] add "XFAIL: nvptx" for some tests

[Igor Chebykin via Phabricator via llvm-commits]

i-chebykin added inline comments.


================
Comment at: llvm/test/CodeGen/Generic/addr-label.ll:6
 
+; NVPTX unexpectedly emitted of the global var, while the function is not emitted as expected
+; XFAIL: nvptx
----------------
tra wrote:
> Wrong description?
> AFAICT it fails with a crash on failure to select https://godbolt.org/z/cdfE3bo4W:
> `Cannot select: 0x5608e9078c70: i64 = BlockAddress<@test1b, %test_label> 0`
> 
Right, this is a typo


================
Comment at: llvm/test/CodeGen/Generic/live-debug-label.ll:41-44
 ; CHECK: bye.thread21:
 ; CHECK: DBG_LABEL !14
 ; CHECK: if.then5:
 ; CHECK: DBG_LABEL !14
----------------
tra wrote:
> Something like this would probably work better:
> ```
> ; CHECK: {{bye\.thread21|if\.then5}}:
> ; CHECK: DBG_LABEL !14
> ; Skip to the next label.
> ; CHECK: {{^\s+bb\.}}
> ; CHECK: {{bye\.thread21|if\.then5}}:
> ; CHECK: DBG_LABEL !14
> ; Skip to the next label.
> ; CHECK: {{^\s+bb\.}}
> ; CHECK-NOT: DBG_LABEL !14
> 
> ```

Not sure that we can have simple test for both x86 and nvptx here
I suggest either `XFAIL: nvptx` or do not touch the test in this commit


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124125/new/

https://reviews.llvm.org/D124125