[PATCH] D124275: [lld/mac] For catalyst outputs, tolerate linking against mac-only tbd files

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 22 12:30:07 PDT 2022


thakis added a comment.

thanks!



================
Comment at: lld/MachO/InputFiles.cpp:1129
+        auto file = make<DylibFile>(child, umbrella, /*isBundleLoader=*/false,
+                                    umbrella->hasSeparateMacAndCatalystVersion);
         file->parseReexports(child);
----------------
int3 wrote:
> should we have a test case that covers re-exports with separate versions?
Oh hmm good point, I'll look into it (before landing).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124275/new/

https://reviews.llvm.org/D124275



More information about the llvm-commits mailing list