[PATCH] D124153: [CMake] Change default CMAKE_BUILD_TYPE to Release

[Tom Stellard via Phabricator via llvm-commits]

tstellar added a comment.

In D124153#3468477 <https://reviews.llvm.org/D124153#3468477>, @erichkeane wrote:

> If you want a 'right' default, it has to be 'the one that most users of cmake WANT'.  I posit that is 'default' or 'release with debug info + asserts', since MOST direct users of our cmake scripts are going to be developers.  I'd find 'no default' to be a vast improvement over 'give me the wrong one'.

I think the default  should be for people who don't have the experience or the knowledge (yet) to know which configuration works best for them or even how to select a different one.  Once people have enough knowledge to know what configuration they want, then they can pass those options to CMake and the default is no longer relevant to them.  Along the same lines, the reason I don't like having no default, is you are forcing someone new to the project to pick a configuration when they may not have any idea which one is best for them.  It's especially an issue when one of the options (Debug build) has a good chance to not be buildable on their system.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124153/new/

https://reviews.llvm.org/D124153