[PATCH] D123434: [lld-macho][nfc] Simplify unwind section lookup

Roger Kim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 22 11:38:40 PDT 2022


Roger added inline comments.


================
Comment at: lld/MachO/InputFiles.cpp:918
+
+  Section *ehFrameSection = nullptr;
+  Section *compactUnwindSection = nullptr;
----------------
int3 wrote:
> Roger wrote:
> > It looks like we do not use this variable aside from assigning to it. Can we get rid of it?
> it's used in the next diff, I don't think finagling with merge conflicts just to relocate it there is worthwhile :P
Sounds good.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123434/new/

https://reviews.llvm.org/D123434



More information about the llvm-commits mailing list