[PATCH] D124275: [lld/mac] For catalyst outputs, tolerate linking against mac-only tbd files

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 22 11:24:29 PDT 2022


int3 accepted this revision.
int3 added a comment.
This revision is now accepted and ready to land.

lgtm



================
Comment at: lld/MachO/InputFiles.cpp:1129
+        auto file = make<DylibFile>(child, umbrella, /*isBundleLoader=*/false,
+                                    umbrella->hasSeparateMacAndCatalystVersion);
         file->parseReexports(child);
----------------
should we have a test case that covers re-exports with separate versions?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124275/new/

https://reviews.llvm.org/D124275



More information about the llvm-commits mailing list