[PATCH] D124153: [CMake] Change default CMAKE_BUILD_TYPE to Release

[Tom Stellard via Phabricator via llvm-commits]

tstellar added a comment.

In D124153#3468341 <https://reviews.llvm.org/D124153#3468341>, @aaron.ballman wrote:

> In D124153#3468313 <https://reviews.llvm.org/D124153#3468313>, @tstellar wrote:
>
>> @aaron.ballman There's some people that can't build in debug mode at all because there machine is not powerful enough.  For me, this is enough to disqualify it from being the default, because it's creating a barrier of entry for new users/developers.
>
> The same is true for making release builds; you can OOM a machine trivially when linking. To me, the barrier to entry isn't that the default build mode is wrong, it's that we've not done a good job of making our project buildable without a build farm or super computer. I think changing the default build mode to release is a bit like using a teaspoon to bail out a leaking boat; it's incrementally better than nothing, but it's really not addressing the problem or likely to make a significant difference.

I think we pretty much agree on everything here, except I do think build mode will actually help reduce this problem a lot.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124153/new/

https://reviews.llvm.org/D124153