[PATCH] D124153: [CMake] Change default CMAKE_BUILD_TYPE to Release

[Tobias Hieta via Phabricator via llvm-commits]

thieta added a comment.

In D124153#3467803 <https://reviews.llvm.org/D124153#3467803>, @tschuett wrote:

> Rather than changing the default and annoying or confusing people, improve the documentation! Have cmake print a link to the awesome documentation.

Are you suggesting that it should print the link to the documentation if there is no build_type specified or do you have another suggestion when the link should be printed?

While I always think the documentation could be improved I am not sure just improving documentation is the solution here, unless we pair it with erroring out if no explicit build_type is set. It won't be discovered otherwise.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124153/new/

https://reviews.llvm.org/D124153