[PATCH] D123576: Support constructing empty function_ref from other callables that can be "empty"

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 22 09:02:10 PDT 2022


dblaikie added a subscriber: rsmith.
dblaikie added a comment.

I worry this is overly general (it's not obvious that any functor with boolean conversion has the semantics this patch relies on) & inconsistent with the standard library (`std::function` for instance doesn't provide this (or a narrower version of it) functionality - so we'll still have the bugs for any API that takes a `function_ref` and passes it to `std::function`)

I don't know that there's /no/ useful direction here, but I have my reservations.

(@rsmith as the original author of `function_ref`)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123576/new/

https://reviews.llvm.org/D123576



More information about the llvm-commits mailing list