[PATCH] D123975: [RISCV] Add rvv codegen support for vp.fpext.

[Fraser Cormack via Phabricator via llvm-commits]

frasercrmck added a comment.

If I've read this correctly, this isn't strictly the same behaviour for fixed-length `ISD::FP_EXTEND` because it used to use `ISD::FP_EXTEND` for intermediate extends, whereas now it consistently uses `RISCVISD::FP_EXTEND_VL`. I wonder if we silently went through the same change when `ISD::FP_ROUND` was merged with `ISD::VP_FP_ROUND`.

This isn't necessarily a problem as evidently the existing tests haven't changed, but it should probably be noted in the commit description at least.



================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:3277
-
-    SDValue Extend = getRVVFPExtendOrRound(IntermediateExtend, VT, ContainerVT,
-                                           DL, DAG, Subtarget);
----------------
You've removed the last use of `getRVVFPExtendOrRound` here, haven't you?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123975/new/

https://reviews.llvm.org/D123975