[PATCH] D124232: [AMDGPU] Use d16 flag for image.sample instructions

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 22 07:39:01 PDT 2022


foad added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUInstCombineIntrinsic.cpp:222
+  // Try to use D16
+  if (ST->hasD16LoadStore()) {
+
----------------
I think this should be `hasD16Images()` but I'm not 100% sure. You could check by running your test case through llc with -mcpu=gfx810 to see if it manages to generate valid ISA.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124232/new/

https://reviews.llvm.org/D124232



More information about the llvm-commits mailing list