[PATCH] D124218: [LoadStoreVectorizer] Consider if operation is faster than before

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 22 03:17:12 PDT 2022


foad added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoadStoreVectorizer.cpp:1086
+      accessIsMisaligned(EltSzInBytes, AS, Alignment, FastBefore);
+      if (FastBefore > Fast)
+        return false;
----------------
It is not at all clear to me whether it makes sense to compare `FastBefore` with `Fast` directly, or whether one of them needs to be multiplied by `ChainSize`. Especially since the definition of `Fast` is target-specific.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124218/new/

https://reviews.llvm.org/D124218



More information about the llvm-commits mailing list