[PATCH] D124187: [RISCV] Print human-readable VTYPE/SEW/LMUL in MIR

[Fraser Cormack via Phabricator via llvm-commits]

frasercrmck marked an inline comment as done.
frasercrmck added inline comments.


================
Comment at: llvm/test/CodeGen/RISCV/rvv/addi-scalable-offset.mir:43
+    ; CHECK-NEXT: dead $x0 = PseudoVSETVLI killed renamable $x11, 88 /* e64, m1, ta, mu */, implicit-def $vl, implicit-def $vtype
+    ; CHECK-NEXT: renamable $v8 = PseudoVLE64_V_M1 killed renamable $x10, $noreg, 6 /* e64,m1 */, implicit $vl, implicit $vtype :: (load unknown-size from %ir.pa, align 8)
     ; CHECK-NEXT: $x11 = PseudoReadVLENB
----------------
craig.topper wrote:
> frasercrmck wrote:
> > I wrote this when vsetvli was still printing without spaces between tokens. Presumably this should follow suit and have a space, for consistency?
> Is printing m1 redundant with the instruction name?
Arguably, yeah... It's also not *really* part of the SEW operand and so might cause confusion when seeing how it's printed, so I've dropped it.


================
Comment at: llvm/test/CodeGen/RISCV/rvv/emergency-slot.mir:144
   ; CHECK-NEXT:   $x1 = LD $x2, 8 :: (load (s64) from %stack.15)
-  ; CHECK-NEXT:   renamable $v0 = PseudoVSLIDEDOWN_VX_M1 undef renamable $v0, killed renamable $v0, killed renamable $x13, $noreg, 8, implicit $vl, implicit $vtype
-  ; CHECK-NEXT:   renamable $x13 = PseudoVMV_X_S_M1 killed renamable $v0, 8, implicit $vl, implicit $vtype
+  ; CHECK-NEXT:   renamable $v0 = PseudoVSLIDEDOWN_VX_M1 undef renamable $v0, killed renamable $v0, killed renamable $x13, $noreg, 8 /* e256,m1 */, implicit $vl, implicit $vtype
+  ; CHECK-NEXT:   renamable $x13 = PseudoVMV_X_S_M1 killed renamable $v0, 3 /* e8,m1 */, implicit $vl, implicit $vtype
----------------
craig.topper wrote:
> Was this test not updated when we converted from SEW to Log2SEW?
Apparently not. I couldn't find any hints about what could have happened. I've pushed rG9687ca970f77 to fix this test up separately. I'm not sure why I didn't update the vslidedowns in this patch, though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124187/new/

https://reviews.llvm.org/D124187