[PATCH] D124214: [libc][NOT FOR COMMIT] building LLVM-libc on 32 bit arm with gcc

[Guillaume Chatelet via Phabricator via llvm-commits]

gchatelet added inline comments.


================
Comment at: libc/cmake/modules/LLVMLibCCheckCpuFeatures.cmake:10
   set(ALL_CPU_FEATURES SSE2 SSE4_2 AVX2 AVX512F)
-  set(LIBC_COMPILE_OPTIONS_NATIVE -march=native)
+  # set(LIBC_COMPILE_OPTIONS_NATIVE -march=native)
 elseif(${LIBC_TARGET_ARCHITECTURE_IS_AARCH64})
----------------
Which gcc version is this?


================
Comment at: libc/src/__support/CPP/TypeTraits.h:53
+      IsSameV<unsigned long long, TypeNoCV> || IsSameV<bool, TypeNoCV>
+      // || IsSameV<__uint128_t, TypeNoCV> || IsSameV<__int128_t, TypeNoCV>
+      ;
----------------
  #ifdef __SIZEOF_INT128__
       || IsSameV<__uint128_t, TypeNoCV> || IsSameV<__int128_t, TypeNoCV>
  #endif // __uint128_t


================
Comment at: libc/src/string/memory_utils/utils.h:21
+#elif defined(LLVM_LIBC_ARCH_ARM)
+#define LLVM_LIBC_CACHELINE_SIZE 32 // This number is just a guess.
 #else
----------------
It's... complicated

https://github.com/abseil/abseil-cpp/blob/master/absl/base/optimization.h#L83-L93


================
Comment at: libc/test/src/string/CMakeLists.txt:272
 
-add_libc_multi_impl_test(bcmp SRCS bcmp_test.cpp)
-add_libc_multi_impl_test(bzero SRCS bzero_test.cpp)
-add_libc_multi_impl_test(memcmp SRCS memcmp_test.cpp)
-add_libc_multi_impl_test(memcpy SRCS memcpy_test.cpp)
-add_libc_multi_impl_test(memmove SRCS memmove_test.cpp)
-add_libc_multi_impl_test(memset SRCS memset_test.cpp)
+# add_libc_multi_impl_test(bcmp SRCS bcmp_test.cpp)
+# add_libc_multi_impl_test(bzero SRCS bzero_test.cpp)
----------------
Could you copy/paste the error message?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124214/new/

https://reviews.llvm.org/D124214