[PATCH] D124223: [lld-macho] Fix ICF crash when comparing symbol relocs

[Vincent Lee via Phabricator via llvm-commits]

thevinster added inline comments.


================
Comment at: lld/test/MachO/icf-literals.s:80
+  leaq _foo2-32(%rip), %rax
+_foo1_pos_offset_ref:
+  leaq _foo1+4(%rip), %rax
----------------
Is there reason why we need to also have the `pos_offset` cases? It looks like it's exercising the same logic as the `neg_offset` right? Also, would it be possible to also have a test case for the section relocs comparison?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124223/new/

https://reviews.llvm.org/D124223