[PATCH] D120544: [AMDGPU] Omit unnecessary waitcnt before barriers
Marek Olšák via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 21 21:49:25 PDT 2022
mareko added a comment.
In D120544#3464886 <https://reviews.llvm.org/D120544#3464886>, @nhaehnle wrote:
> Oh, I misunderstood what this patch does. It's possibly an unfortunate interaction between Mesa and LLVM, where Mesa assumed that the waitcnt was there, and your removal of it causes problems. In that case, can you please coordinate with Mesa to make sure it starts adding the required fence instructions in the LLVM IR? Cc @mareko
I'm interested in what to do in Mesa. Do we just need to add LLVMBuildFence(... LLVMAtomicOrderingRelease ...) before amdgcn.s.barrier?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120544/new/
https://reviews.llvm.org/D120544
More information about the llvm-commits
mailing list