[PATCH] D124153: [CMake] Change default CMAKE_BUILD_TYPE to Release

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added a comment.

In D124153#3466424 <https://reviews.llvm.org/D124153#3466424>, @tstellar wrote:

> I disagree about erroring out when CMAKE_BUILD_TYPE is undefined.  We want to make the build easy for new users, so I think it's important that the default build (cmake with no arguments) just works.

Why isn’t it easy to copy/paste one option clearly presented by the cmake invocation? That seems like a good user experience to me: there is a fairly simple choice to be made and we expose it concisely and directly, it’s not like there is an obscure error and the user needs to read a doc…
It’s not like every command line tool works without mandatory options.

> I also think the default should be release build with asserts disabled.

I’d be fine with this though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124153/new/

https://reviews.llvm.org/D124153