[PATCH] D123845: [BPF] Enable IAS in backend

Thu Apr 21 20:28:04 PDT 2022

brad added a comment.

In D123845#3458214 <https://reviews.llvm.org/D123845#3458214>, @yonghong-song wrote:

> The `UseIntegratedAssembler = false` is added with the following commit,
>
>   commit d2e5157c1f0b1953c5166c1d656ac71e840615a4
>   Author: Fangrui Song <i at maskray.me>
>   Date:   Sat Apr 11 10:01:36 2020 -0700
>   
>       [MC] Add UseIntegratedAssembler = false. NFC
>
> Do you know what changed to remove `UseIntegratedAssembler = false;`? Does this change has any real impact on BPF backend?

That commit was to offset this commit after that, since IAS was not already enabled in the backend..

commit 0a55d3f557a74cfb459b24e442072302d5444baf <https://reviews.llvm.org/rG0a55d3f557a74cfb459b24e442072302d5444baf>
Author: Fangrui Song <i at maskray.me>
Date:   Sat Apr 11 10:06:18 2020 -0700

  [MC] Default MCAsmInfo::UseIntegratedAssembler to true

Well nothing changed. As far as I can see IAS for BPF has been enabled for a long time with the Clang frontend. It should be enabled in the BPF backend as well. Almost all
other backends do as well.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123845/new/

https://reviews.llvm.org/D123845