[PATCH] D124212: [sanitizer] Use canonical syscalls everywhere

[Evgenii Stepanov via Phabricator via llvm-commits]

eugenis marked an inline comment as done.
eugenis added inline comments.


================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_linux.cpp:356-365
+#    elif SANITIZER_LINUX_USES_64BIT_SYSCALLS
+#      if defined(__mips64)
   // For mips64, stat syscall fills buffer in the format of kernel_stat
   struct kernel_stat kbuf;
   int res = internal_syscall(SYSCALL(stat), path, &kbuf);
   kernel_stat_to_stat(&kbuf, (struct stat *)buf);
   return res;
----------------
pcc wrote:
> Is this code dead now? I think SANITIZER_LINUX_USES_64BIT_SYSCALLS can only be true if SANITIZER_LINUX is.
I think it is! Removed.

We also need to do something prepocessor code formatting. This spacing is insane and makes the code unreadable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124212/new/

https://reviews.llvm.org/D124212