[PATCH] D124206: [BOLT][NFC] Reduce Target/{AArch64, X86} dependencies

[Amir Ayupov via Phabricator via llvm-commits]

Amir created this revision.
Herald added subscribers: ayermolo, pengfei, kristof.beyls, mgorny.
Herald added a reviewer: rafauler.
Herald added a reviewer: maksfb.
Herald added a project: All.
Amir requested review of this revision.
Herald added subscribers: llvm-commits, yota9.
Herald added a project: LLVM.

We don't actually depend on entire X86/AArch64 components that pull in CodeGen,
SelectionDAG etc., just the Desc part with opcode and other definitions.

Note that it still doesn't decouple BOLT from these components - we still pull
in X86 and AArch64 from top-level llvm-bolt dependencies as we use assembler and
disassembler. It's difficult to reduce these as this requires non-trivial 
changes to X86/AArch64 components themselves (e.g. moving out AsmPrinter).


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D124206

Files:
  bolt/lib/Target/AArch64/CMakeLists.txt
  bolt/lib/Target/X86/CMakeLists.txt


Index: bolt/lib/Target/X86/CMakeLists.txt
===================================================================
--- bolt/lib/Target/X86/CMakeLists.txt
+++ bolt/lib/Target/X86/CMakeLists.txt
@@ -2,17 +2,18 @@
   BOLTCore
   BOLTUtils
   MC
-  Object
   Support
-  ${LLVM_TARGETS_TO_BUILD}
+  X86Desc
   )
 
 add_llvm_library(LLVMBOLTTargetX86
   X86MCPlusBuilder.cpp
 
   DEPENDS
-  intrinsics_gen
   X86CommonTableGen
   )
 
-include_directories(${LLVM_MAIN_SRC_DIR}/lib/Target/X86 ${LLVM_BINARY_DIR}/lib/Target/X86)
+include_directories(
+  ${LLVM_MAIN_SRC_DIR}/lib/Target/X86
+  ${LLVM_BINARY_DIR}/lib/Target/X86
+  )
Index: bolt/lib/Target/AArch64/CMakeLists.txt
===================================================================
--- bolt/lib/Target/AArch64/CMakeLists.txt
+++ bolt/lib/Target/AArch64/CMakeLists.txt
@@ -1,17 +1,18 @@
 set(LLVM_LINK_COMPONENTS
   BOLTCore
   MC
-  Object
   Support
-  ${LLVM_TARGETS_TO_BUILD}
+  AArch64Desc
   )
 
 add_llvm_library(LLVMBOLTTargetAArch64
   AArch64MCPlusBuilder.cpp
 
   DEPENDS
-  intrinsics_gen
   AArch64CommonTableGen
   )
 
-include_directories(${LLVM_MAIN_SRC_DIR}/lib/Target/AArch64 ${LLVM_BINARY_DIR}/lib/Target/AArch64)
+include_directories(
+  ${LLVM_MAIN_SRC_DIR}/lib/Target/AArch64
+  ${LLVM_BINARY_DIR}/lib/Target/AArch64
+  )


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D124206.424311.patch
Type: text/x-patch
Size: 1293 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220421/86301983/attachment.bin>