[PATCH] D123010: [asan] Emit .size directive for global object size before redzone

Mitch Phillips via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 21 13:44:33 PDT 2022


hctim accepted this revision.
hctim added a comment.
This revision is now accepted and ready to land.

I just did a quick check against `llvm/test/Instrumentation/AddressSanitizer/adaptive_global_redzones.ll`, compiling and linking it as a DSO, and it looks right (only the sizes change).

One thing to bear in mind is that some sanitizers (like HWASan) also change the alignment of the global variables as well as the size, so sanitizers will always be an ABI break, but I agree this patch makes things less confusing rather than more confusing.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123010/new/

https://reviews.llvm.org/D123010



More information about the llvm-commits mailing list