[PATCH] D123822: [compiler-rt][lsan] Share platform allocator settings between ASan and LSan

[Leonard Chan via Phabricator via llvm-commits]

leonardchan added inline comments.


================
Comment at: compiler-rt/lib/asan/asan_allocator.h:129-142
-# elif defined(__aarch64__) && SANITIZER_ANDROID
-// Android needs to support 39, 42 and 48 bit VMA.
-const uptr kAllocatorSpace =  ~(uptr)0;
-const uptr kAllocatorSize  =  0x2000000000ULL;  // 128G.
-typedef VeryCompactSizeClassMap SizeClassMap;
-#elif SANITIZER_RISCV64
-const uptr kAllocatorSpace = ~(uptr)0;
----------------
vitalybuka wrote:
> i suspect these smaller values has something to do with ability allocate shadow, which is not an issue for lsan
Do you recommend I should remove them?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123822/new/

https://reviews.llvm.org/D123822