[PATCH] D122251: [lit] Use sharding for GoogleTest format

Thu Apr 21 12:50:07 PDT 2022

ychen added a comment.

In D122251#3465359 <https://reviews.llvm.org/D122251#3465359>, @sammccall wrote:

> In D122251#3465326 <https://reviews.llvm.org/D122251#3465326>, @sammccall wrote:
>
>> After this change, failure details from unittests are not printed both locally and on bots: https://lab.llvm.org/buildbot/#/builders/109/builds/37071
>> (Assuming this is a bug that can be fixed)
>
> Having read the change more carefully, it sounds like it's *expected* that a crashing unittest no longer prints a stack trace on stdout.
>
> I think this is an unacceptable regression. Crashes/asserts are a common way that tests fail and the stack trace from a debug build is how we investigate them.
> The rerun commands are hard to find, require manually rebuilding to iterate on, and don't filter output to the test in question as lit did (prior to this change).
> Moreover, it's not possible to manually rerun the test on a bot, and many times the crash trace/assertion messages from buildbots have been *critical* to debugging failures that only occur in certain buildbot configurations (e.g. platforms I don't have access to).
> Finally, some crashes are rare/nondeterministic, and so rerunning is not always a good option.
>
> I'm not familiar enough with this part of lit to suggest solutions here.
> But can this be reverted or made an off-by-default option until it can provide equivalent information & convenience?

Thanks for the feedback. I think there is a way to address this. Give me one day or two.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122251/new/

https://reviews.llvm.org/D122251