[PATCH] D122857: [LoopCacheAnalysis] Enable delinearization of fixed sized arrays

Thu Apr 21 12:24:48 PDT 2022

congzhe added a comment.

In D122857#3465404 <https://reviews.llvm.org/D122857#3465404>, @Meinersbur wrote:

> In D122857#3464913 <https://reviews.llvm.org/D122857#3464913>, @congzhe wrote:
>
>> I wonder if you could clarify what you meant by "continue with this patch"? I would certainly like to continue with the current patch if possible, but due to opaque pointers it seems that the current approach in this patch become fragile and not viable?
>
> I would not block this based only on a possible future development, taking into account that there are already uses of `getIndexExpressionsFromGEP` (e.g. by DA) and there is a possible workaround.

Thanks Michael, that does sound good to me. I've already addressed the comments in this patch in its current form. Moving forward I guess we could do one of the following:

1. go ahead trying to merge it and do the refactoring (as mentioned in https://reviews.llvm.org/D122857#3450657) in the next patch, or
2. modify this patch to do refactoring in the current patch.

I am leaning towards (1) since it might be easier to track the changes, as compared to doing a whole lot of work in one patch. But I don't have a strong preference and I'll be glad to take either option (and any other possible option).

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122857/new/

https://reviews.llvm.org/D122857