[PATCH] D124194: [AMDGPU] Correctly set `IsKill` flag for VGPR custom spills in the prolog

Christudasan Devadasan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 21 12:16:25 PDT 2022


cdevadas created this revision.
cdevadas added reviewers: arsenm, rampitec, sebastian-ne.
Herald added subscribers: hsmhsm, foad, kerbowa, hiraditya, t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, kzhuravl, qcolombet.
Herald added a project: All.
cdevadas requested review of this revision.
Herald added subscribers: llvm-commits, wdng.
Herald added a project: LLVM.

We always assume the vector register is dead or killed while
inserting the custom spills in the prolog. It is not always
true. Used the entry block liveIn data while setting the flag.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D124194

Files:
  llvm/lib/Target/AMDGPU/SIFrameLowering.cpp
  llvm/test/CodeGen/AMDGPU/av_spill_cross_bb_usage.mir
  llvm/test/CodeGen/AMDGPU/pei-scavenge-sgpr-carry-out.mir
  llvm/test/CodeGen/AMDGPU/pei-scavenge-sgpr-gfx9.mir
  llvm/test/CodeGen/AMDGPU/pei-scavenge-sgpr.mir
  llvm/test/CodeGen/AMDGPU/pei-scavenge-vgpr-spill.mir
  llvm/test/CodeGen/AMDGPU/spill-reg-tuple-super-reg-use.mir
  llvm/test/CodeGen/AMDGPU/track-spilled-vgpr-liveness.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D124194.424261.patch
Type: text/x-patch
Size: 15918 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220421/2527179b/attachment.bin>


More information about the llvm-commits mailing list