[PATCH] D122251: [lit] Use sharding for GoogleTest format
Sam McCall via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 21 11:32:43 PDT 2022
sammccall added a comment.
After this change, failure details from unittests are not printed both locally and on bots: https://lab.llvm.org/buildbot/#/builders/109/builds/37071
(Assuming this is a bug that can be fixed)
Also the summary of "failed tests" at the end is now not useful:
Failed Tests (6):
Clangd Unit Tests :: ./ClangdTests/114/134
Clangd Unit Tests :: ./ClangdTests/115/134
Clangd Unit Tests :: ./ClangdTests/128/134
Clangd Unit Tests :: ./ClangdTests/42/134
Clangd Unit Tests :: ./ClangdTests/78/134
Clangd Unit Tests :: ./ClangdTests/87/134
This is critical information (e.g. to pick the simplest test to start debugging) and having to scan through the test outputs to try to find the actual failing test names is a large regression.
Is there a plan to address this?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122251/new/
https://reviews.llvm.org/D122251
More information about the llvm-commits
mailing list