[PATCH] D124183: [InstCombine] Add one use limitation for (X * C2) << C1 --> X * (C2 << C1)

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

In D124183#3465290 <https://reviews.llvm.org/D124183#3465290>, @bcl5980 wrote:

> One other reason I insist one-use is we can give programmer choice. If we remove one-use, there is no choice for programmer.
> https://godbolt.org/z/Wrzh5aczf
> https://godbolt.org/z/1nGf88E87

Apologies, i do not really understand what you mean by a choice here.

In D124183#3465313 <https://reviews.llvm.org/D124183#3465313>, @bcl5980 wrote:

> @spatel Do you agree with @lebedev.ri to revert both one-use? If yes I will revert both of them.

Note that i was not asking for the revert, and there is really no need to revert the D123453 <https://reviews.llvm.org/D123453>, if needed it can be adjusted in a new commit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124183/new/

https://reviews.llvm.org/D124183