[PATCH] D124187: [RISCV] Print human-readable VTYPE/SEW/LMUL in MIR

Fraser Cormack via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 21 10:31:20 PDT 2022


frasercrmck added a comment.

I've had this patch kicking around locally for a long time and was never sure whether the extra verbosity would be welcome. So I thought I'd throw it out there to see what people think.



================
Comment at: llvm/test/CodeGen/RISCV/rvv/addi-scalable-offset.mir:43
+    ; CHECK-NEXT: dead $x0 = PseudoVSETVLI killed renamable $x11, 88 /* e64, m1, ta, mu */, implicit-def $vl, implicit-def $vtype
+    ; CHECK-NEXT: renamable $v8 = PseudoVLE64_V_M1 killed renamable $x10, $noreg, 6 /* e64,m1 */, implicit $vl, implicit $vtype :: (load unknown-size from %ir.pa, align 8)
     ; CHECK-NEXT: $x11 = PseudoReadVLENB
----------------
I wrote this when vsetvli was still printing without spaces between tokens. Presumably this should follow suit and have a space, for consistency?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124187/new/

https://reviews.llvm.org/D124187



More information about the llvm-commits mailing list