[PATCH] D124052: [DWARF] Add API to get data from MCDwarfLineStr
Alexander Yermolovich via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 21 09:29:17 PDT 2022
ayermolo added a comment.
In D124052#3463847 <https://reviews.llvm.org/D124052#3463847>, @dblaikie wrote:
> Generally we'd rather not commit untested functionality - /probably/ this should be either unit tested in this commit, or rolled into whatever commit calls/exercises the functionality. But if you reckon this is really the better separation, I won't insist on that, but give it some thought.
Thanks. I'll add a unit test. Probably more inline with what I have seen from other diffs of breaking them up if possible. The other commit is already pretty big.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124052/new/
https://reviews.llvm.org/D124052
More information about the llvm-commits
mailing list