[PATCH] D124153: [CMake] Change default CMAKE_BUILD_TYPE to Release

[Andrzej Warzynski via Phabricator via llvm-commits]

awarzynski added a comment.

Makes sense to me, thanks for proposing and working on this!

Would you be able to update relevant docs as well? For example, from Getting Started with the LLVM System <https://github.com/llvm/llvm-project/blob/3d0e0e1027203fe5e89104ad81ee7bb53e525f95/llvm/docs/GettingStarted.rst#getting-the-source-code-and-building-llvm>:

  -DCMAKE_BUILD_TYPE=type --- Valid options for type are Debug, Release, RelWithDebInfo, and MinSizeRel. Default is Debug.

Not sure about LLVM Testing Infrastructure Guide <https://github.com/llvm/llvm-project/blob/3d0e0e1027203fe5e89104ad81ee7bb53e525f95/llvm/docs/TestingGuide.rst#unit-and-regression-tests>:

  % cmake -DCMAKE_BUILD_TYPE="Release" -DLLVM_ENABLE_ASSERTIONS=On

Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124153/new/

https://reviews.llvm.org/D124153