[PATCH] D124106: [lld/mac] Warn that writing zippered outputs isn't implemented

[Nico Weber via Phabricator via llvm-commits]

thakis added inline comments.


================
Comment at: lld/MachO/Driver.cpp:649-650
+    // write zippered executables.
+    warn("writing zippered outputs not yet implemented, "
+         "ignoring all but last -platform_version flag");
+  }
----------------
thakis wrote:
> oontvoo wrote:
> > Should we verify that this is indeed because of the zippered dylib expansion of arguments?
> > (This is now assuming that whenever two or more platform_version arguments are passed, it is because of the zippered dylib, but that might not always be the case, eg. users accidentally pass the args multiple times)
> > Warning "writing zippered outputs..." here would be a bit confusing.
> > 
> > 
> How would you verify this? If users typo this, they _will_ get zippered output once we implement support for that (and they do get that with ld64).
> 
> (If more more than 2 platform_version args are passed, they'll get the "must specify -platform_version at most twice" diag further up.)
Oh, and passing the flag multiple times for the _same_ platform doesn't emit this warning: 

```
% out/gn/bin/ld64.lld -dylib -arch arm64 -platform_version macos 12.0.0 12.3 -platform_version macos 12.0.0 12.3 foo.o
# ^ no diag
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124106/new/

https://reviews.llvm.org/D124106