[PATCH] D110972: [DA] Handle mismatching loop levels by updating the numbering scheme

Thu Apr 21 08:45:07 PDT 2022

Meinersbur added a comment.

In D110972#3463979 <https://reviews.llvm.org/D110972#3463979>, @congzhe wrote:

> Are you essentially suggesting that we follow the approach in D110973 <https://reviews.llvm.org/D110973>, and improve it by using `getSCEVAtScope()` such that we may be able to infer some of those `AddRec` (like in the lcssa case) to be loop invariant with respect to `LoopNest`?

yes. `ScalarEvolution::computeLoopDisposition() == LoopInvariant` might be the designated API for this.

> If that is the case then we may want to add another test that is a mirror of `@test1` but not using `undef` as the loop exit condition?

We preferably do not want undef at all in test cases, it makes them fragile.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110972/new/

https://reviews.llvm.org/D110972