[PATCH] D124143: [lld-macho] Allow dead_strip to work with autohide symbols that cannot be exported
Nico Weber via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 21 06:49:07 PDT 2022
thakis added inline comments.
================
Comment at: lld/MachO/MarkLive.cpp:234
// explicitUndefineds code below would handle this automatically.
- assert(!defined->privateExtern &&
- "should have been rejected by driver");
marker->addSym(defined);
continue;
----------------
Should we call addSym for privateExterns? That seems wrong (?)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124143/new/
https://reviews.llvm.org/D124143
More information about the llvm-commits
mailing list