[PATCH] D124153: [CMake] Change default CMAKE_BUILD_TYPE to Release

[Tobias Hieta via Phabricator via llvm-commits]

thieta added a comment.

Here is an attempt at the logic described above - here is what it does now:

  ➜ cmake -GNinja ../llvm > /dev/null && grep LLVM_ENABLE_ASSERTIONS CMakeCache.txt && rm CMakeCache.txt
  LLVM_ENABLE_ASSERTIONS:BOOL=ON
  ➜ cmake -GNinja -DCMAKE_BUILD_TYPE=Release ../llvm > /dev/null && grep LLVM_ENABLE_ASSERTIONS CMakeCache.txt && rm CMakeCache.txt
  <nothing here means OFF>
  ➜ cmake -GNinja -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_ASSERTIONS=ON ../llvm > /dev/null && grep LLVM_ENABLE_ASSERTIONS CMakeCache.txt && rm CMakeCache.txt
  LLVM_ENABLE_ASSERTIONS:INTERNAL=ON
  ➜ cmake -GNinja -DCMAKE_BUILD_TYPE=Debug ../llvm > /dev/null && grep LLVM_ENABLE_ASSERTIONS CMakeCache.txt && rm CMakeCache.txt
  LLVM_ENABLE_ASSERTIONS:BOOL=ON

Does that look right?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124153/new/

https://reviews.llvm.org/D124153