[PATCH] D123910: [HWAsan] Support 4K/8K/16K/64K page size to ring buffer

[Xiaodong Liu via Phabricator via llvm-commits]

XiaodongLoong added a comment.

In D123910#3462916 <https://reviews.llvm.org/D123910#3462916>, @eugenis wrote:

> I still think that my proposal in the comment above is way better than adding an ABI-breaking compiler flag.

OK, I read the proposal https://github.com/google/sanitizers/issues/1446.

  Using pagesize here would be wasteful - ex. on Android we default to a
  single 4Kb page for the stack ring buffer. I'd rather replace the mmap in
  SavedStackAllocations with InternalAlloc , this should solve the problem.
  
  There is also an efficiency issue in HwasanThreadList::DontNeedThread - if
  the buffer is smaller than a page, it will never be able to release
  anything. That's a bit harder to fix, and I'm not sure how significant it
  actually is.

I'm looking forward to your revision.

Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123910/new/

https://reviews.llvm.org/D123910